Enable dynamic catalogs for product-tests #24633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this uses the default catalog store set to `file`, there should not be issues with switching it all over to dynamic catalog management.
Member
Author
|
@hashhar can you enable ci with secrets here, please? |
Member
|
/test-with-secrets sha=7a72a4723f04b0c379727a0515dc8e0c222d2160 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/12641899551 |
Member
|
CI with secrets is green. |
wendigo
approved these changes
Jan 7, 2025
hashhar
approved these changes
Jan 8, 2025
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
A good first step. We can follow up with functional tests (and add more of them once the syntax PR lands).
Member
|
Please make sure you update the PR template @anusudarsan @hashhar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this uses the default catalog store set to
file, there should not be issues with switching it all over to dynamic catalog management.Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: